fix: update config settings and footer settings separately #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
gweiying
force-pushed
the
feat/contact-us-page
branch
from
9bf2a22 to
da7dbf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
postupdate method on theSettingsclass to update each component (footerSettings,configSettings) separately, only if the relevant component is defined in the received payload.This is because on the Edit Contact-Us page (link), we only update a key-value pair stored in
footerSettings, so there is no need to store and resendconfigSettingson thepostupdate.The implementation is a currently rough implementation for the frontend PR, and will be cleaned up, see (frontend TODOs list link)