feat: return sites from db for email login #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
harishv7
requested review from
seaerchin,
kishore03109,
QiluXie and
alexanderleegs
and removed request for
seaerchin
harishv7
commented
May 5, 2023
| @@ -128,7 +128,6 @@ export class SitesRouter { | |||
|
|
|||
| router.get( | |||
| "/", | |||
| this.statsMiddleware.countGithubSites, | |||
There was a problem hiding this comment.
Removing the countGithubSites middleware to prevent excessive calls to github
cc @isomerpages/iso-engineers
Comment on lines
+18
to
+21
| lastUpdated?: GitHubRepositoryData["pushed_at"] | ||
| permissions?: GitHubRepositoryData["permissions"] | ||
| repoName: GitHubRepositoryData["name"] | ||
| isPrivate: GitHubRepositoryData["private"] | ||
| isPrivate?: GitHubRepositoryData["private"] |
There was a problem hiding this comment.
hmm actually removing isPrivate has implications specifically for loading homepages on private repos - without this param available the images on editHomepage don't load properly. I feel like this can be a future fix though since the affected repos should be small, but let's check with prod ops first if any existing email login sites are private
There was a problem hiding this comment.
We should then be tracking this info in our DB right? Should we add a column to track this?
But yes, for now, lets check with Ops
kishore03109
approved these changes
May 5, 2023
alexanderleegs
added a commit
that referenced
this pull request
May 9, 2023
* fix: close pull request (#751) * Fix: publish button delay (#752) * Fix: publish button delay * Fix: tests * Fix: move review request status check into router * feat: return sites from db for email login (#754) * feat: return sites from db for email login * fix: tests * fix: use lodash function for type guard * fix(githhub service): get call to github to prevent race condition (#756) * fix(githhub service): get call to github to prevent race condition * fix(github service): throw error if directory name not defined * style(github service): add comments for clarity * fix: tests --------- Co-authored-by: Alexander Lee <[email protected]> * Fix: handle updating of files in root directory (#761) * fix: create .keep first when rename subfolder (#762) * 0.26.0 --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: Alexander Lee <[email protected]> Co-authored-by: Harish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are making unnecessary Github calls on /sites page especially on email login flow when this could be a call to our DB. In light of us reaching the limits of Github api, we should try to prevent excessive calls.
Closes IS-165
Solution
Added a check on getSites to return the list of site names for the user from our DB (only if it is a non-admin and non-github flow user).
Breaking Changes
Deploy Notes
Note minor dependency on isomerpages/isomercms-frontend#1265
Needs to be deployed together