feat(datadog): add tracing for http requests out #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
approved these changes
May 4, 2023
harishv7
approved these changes
May 4, 2023
This was referenced May 4, 2023
seaerchin
added a commit
that referenced
this pull request
May 4, 2023
* fix(site launch email): make table nicer (#732) * fix(site launch email): make table nicer * style(css styles): extract out css styles for better code structure * Fix: add svg to allowed image types (#738) * feat(site creation): add support for email + github logins (#739) * feat(site creation): add support for email + github logins * fix(site creation): fix conditional bugs * fix(Repos Service): fix wrong conditional * fix(site creation): ignore member email for github flow * fix(Infra Service): fix failing build * feat(datadog): add tracing for http requests out (#745) * chore: add logging to endpoints being called (#744) * fix(markdown-utils): add check for falsy values (#746) * 0.25.0 --------- Co-authored-by: Harish <[email protected]> Co-authored-by: Kishore <[email protected]> Co-authored-by: Alexander Lee <[email protected]>
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently we got no observability/metrics for email logins etc, which makes it hard to monitor what routes are being hit..
Solution
Testing
Go to this link and observe that you can sort by
user.type = <email | github>to repro on local, just run this branch + hit an endpoint (either through FE or a client)