Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(env var): change naming of var #719

Merged
merged 2 commits into from
Apr 20, 2023
Merged

style(env var): change naming of var #719

merged 2 commits into from
Apr 20, 2023

Conversation

kishore03109
Copy link
Contributor

Problem

Technically we mock both createDomainAssociation and getDomainAssociation calls, therefore var name is not really accurate

Solution

changing the var name before release today to reflect this.

1pw already updated with the new values.

Deploy notes

new env var:
export MOCK_AMPLIFY_DOMAIN_ASSOCIATION_CALLS="false"

@kishore03109
style(env var): change naming of var
41cb67b 
technically we mock both create and get calls, changing the var name to
reflect this
@kishore03109 kishore03109 marked this pull request as ready for review April 20, 2023 00:07
@kishore03109 kishore03109 requested a review from a team April 20, 2023 00:08
seaerchin
seaerchin approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, remember to update 1pw if needed

@kishore03109 kishore03109 merged commit 15f4863 into develop Apr 20, 2023
@mergify mergify bot deleted the style/clear-env-var-naming branch April 20, 2023 03:32
@alexanderleegs alexanderleegs mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @seaerchin