Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deploymentsservice): add a brand for <env>Url types #705

Merged
merged 1 commit into from
Apr 13, 2023
Merged

chore(deploymentsservice): add a brand for <env>Url types #705

merged 1 commit into from
Apr 13, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

no brand on branded type previously, which resulted in type errors.

Solution

  1. add Brand.fromString

@seaerchin seaerchin requested a review from kishore03109 April 13, 2023 08:17
@seaerchin seaerchin merged commit f50ce80 into develop Apr 13, 2023
@seaerchin seaerchin deleted the chore/add-branding branch April 13, 2023 08:18
@kishore03109 kishore03109 mentioned this pull request Apr 13, 2023
Closed
@alexanderleegs alexanderleegs mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @kishore03109