test(markdown-fixtures): add a test for DOMPurify sanitization #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now, we have no tests for the behaviour of the
sanitize
function, which leads to some behaviour being potentially inconsistent.This was observed in the frontend
sanitize
call vs the backendsanitize
call, where the frontend call preserves the propertyasync
as-is, but the backend call adds the empty string to turn it intoasync=""
.Solution
This PR adds a short test for sanitization to ensure that
from the html spec, the 2 forms (
async
andasync=""
) are equivalent and browser support for the async tag as a whole is wide (only edge support is at v12, others start at v1), so this shouldn't be an issue