chore(site launch form): trim site launch form input #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexanderleegs oh hey this is fair! |
src/utils/formsg-utils.ts
Outdated
Comment on lines
13
to
28
| function trimAllStrings( | ||
| responseArray: string[] | string[][] | ||
| ): string[] | string[][] { | ||
| if (Array.isArray(responseArray)) { | ||
| responseArray.map((item) => { | ||
| if (Array.isArray(item)) { | ||
| return trimAllStrings(item) | ||
| } | ||
| if (typeof item === "string") { | ||
| return item.trim() | ||
| } | ||
| return item | ||
| }) | ||
| return responseArray | ||
| } | ||
| return responseArray |
There was a problem hiding this comment.
Thoughts on reducing the checks here, given that responseArray is string[] | string[][]?
There was a problem hiding this comment.
TS complains if we dont have this because it is not able to infer that
if (Array.isArray(responseArray)), then responseArray is of type []. I have added in a comment for clarity here:
08433bb
src/utils/formsg-utils.ts
Outdated
Comment on lines
36
to
40
| let answers = response?.answerArray | ||
| if (answers) { | ||
| answers = trimAllStrings(answers) | ||
| } | ||
| return response?.answerArray |
There was a problem hiding this comment.
Just checking - does this modify response? I think it might be better to rewrite it so it's clearly regardless
There was a problem hiding this comment.
nope, this is a bug, fixed here 08433bb
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The form expects string values. When typing, it is possible for someone to enter a space in the string
Solution
Defensively trim all inputs