Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(constants): fixed import #694

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(constants): fixed import #694

merged 1 commit into from
Apr 12, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

Old constant was being imported as HOMEPAGE_NAME and not HOMEPAGE_FILENAME

Solution

Fixed import

@seaerchin seaerchin requested a review from a team April 11, 2023 06:14
alexanderleegs
alexanderleegs approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, remember to rebase

@seaerchin seaerchin merged commit 8ca23ec into develop Apr 12, 2023
@seaerchin seaerchin deleted the fix/naming branch April 12, 2023 04:00
@kishore03109 kishore03109 mentioned this pull request Apr 13, 2023
Closed
@alexanderleegs alexanderleegs mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs