chore(review): fix tests for review router #683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Last release added a bunch of checks for sites that are undergoing a migration from github into our db (but not yet completed); this clashes with our code, which expects a fully migrated site (sites table in db populated, site members retrieved from db etc).
This leads to a couple of tests failing in
review.spec.ts
as the calls to calculate those pre-conditions are not mocked. This PR fixes this by mocking said calls.Solution
for methods that have the new checks, there is a new
beforeEach
hook added to mock the call to the precondition. This causes the check to be false (ie, that the site has underwent a full migration), and continues on with the business logic rather than short-circuiting