feat: truncate and remove chars from version desc. before deploy #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2020 19:39
Currently, we get the following error when we attempt to deploy to AWS EB with certain commit messages: ``` Deployment failed: Error: Status: 403. Code: SignatureDoesNotMatch, Message: The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details. ``` This is not because our access key is wrong, but because there are certain characters in our commit message which are not dealt with properly by the beanstalk-deploy package. We know that the following characters have produced problems for us: ``` ( ) ' ``` These are due to encoding issues on the original beanstalk-deploy library. Rather than wait for a fix from the package author, we can first truncate the message, since the title is in the first few words, to lower the chance of a special character, and then we can replace these characters ourselves in the deploy step when setting the version description.
LoneRifle
approved these changes
Nov 4, 2020
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* feat: truncate and remove chars from version desc. before deploy Currently, we get the following error when we attempt to deploy to AWS EB with certain commit messages: ``` Deployment failed: Error: Status: 403. Code: SignatureDoesNotMatch, Message: The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details. ``` This is not because our access key is wrong, but because there are certain characters in our commit message which are not dealt with properly by the beanstalk-deploy package. We know that the following characters have produced problems for us: ``` ( ) ' ``` These are due to encoding issues on the original beanstalk-deploy library. Rather than wait for a fix from the package author, we can first truncate the message, since the title is in the first few words, to lower the chance of a special character, and then we can replace these characters ourselves in the deploy step when setting the version description. * chore: set DEV_BRANCH to be staging-dev Co-authored-by: Jie Hao Kwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, we get the following error when we attempt to deploy to AWS EB with certain commit messages:
This is not because our access key is wrong, but because there are certain characters in our commit message which are not dealt with properly by the beanstalk-deploy package. We know that the following characters have produced problems for us:
These are due to encoding issues on the original beanstalk-deploy library.
Rather than wait for a fix from the package author, we can first truncate the message, since the title is in the first few words, to lower the chance of a special character, and then we can replace these characters ourselves in the deploy step when setting the version description.
Here is a test run where the updated workflow succeeded in deploying.