docs(readme): update readme instructions for running app #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
requested review from
kishore03109,
alexanderleegs and
prestonlimlianjie
seaerchin
commented
Jan 26, 2023
package.json
Outdated
Comment on lines
114
to
116
| "serverless-offline": "^11.0.1", | ||
| "serverless-offline-lambda": "^1.0.6", | ||
| "serverless-plugin-typescript": "^2.1.2", |
There was a problem hiding this comment.
@kishore03109 double checking - all the serverless-xxx stuff can be removed?
package-lock.json
Outdated
| @@ -4,16 +4,6 @@ | |||
| "lockfileVersion": 1, | |||
| "requires": true, | |||
| "dependencies": { | |||
| "2-thenable": { | |||
There was a problem hiding this comment.
Just to double check, are these dependencies all unused?
There was a problem hiding this comment.
not entirely sure how these came to be - if they're in our deps and we can't find a relevant import in our codebase, then i'm assuming they're unused (subpackages should specify their own deps)
There was a problem hiding this comment.
removed all extra dpes
kishore03109
approved these changes
Jan 30, 2023
package.json
Outdated
Comment on lines
114
to
116
| "serverless-offline": "^11.0.1", | ||
| "serverless-offline-lambda": "^1.0.6", | ||
| "serverless-plugin-typescript": "^2.1.2", |
alexanderleegs
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
app requires more setup to run. this isn't well documented so this pr adds the required steps
Solution