fix: removed unnecessary (and failing) cors proxy from git push calls #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc-davis
requested review from
prestonlimlianjie,
alexanderleegs,
seaerchin and
kishore03109
Merged
|
Closing, because this change was brought in by #470. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we merge #470, then we should abandon this PR (because #470 brings in this change as well).
This backend uses the
isomorphic-gitpackage to create repositories and push them to GitHub. Theisomorphic-gitpush method has an optionalcorsProxyargument that allows the package to work in a browser, but is unnecessary in a backend such as this. For some reason, this argument was set tohttps://cors.isomorphic-git.org/, a proxy set up by theisomorphic-gitproject that is only guaranteed to work for requests sent fromhttps://isomorphic-git.github.io/, though it sometimes works from other origins. The configuration of this proxy must have changed on the evening of 11-July-2022, because all of our requests began to fail at that time. The fix is simple: stop using the proxy and everything works.