Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(resourceDirectory): add check for directory/file call order #420

Merged
merged 7 commits into from
Apr 14, 2022

Conversation

seaerchin
Copy link
Contributor

Problem

See #400 for a brief description of the issue.

Closes #400

Solution

  1. add jest-extended
  2. check that directory level calls occur before file level reads

New dev dependencies:

  • jest-extended : package to extend jest and add more matchers

Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments!

Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@seaerchin seaerchin merged commit cf34911 into develop Apr 14, 2022
@seaerchin seaerchin deleted the test/ordering branch April 14, 2022 04:12
This was referenced Apr 14, 2022
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
* build(package): installed jest-extended

* chore(jest.config): update jest config

* build(tsconfig): update tsconfig for jest-extended

* test(resourcedirectory): add test to check call order

* chore(tsconfig): removes file property

* test(resourcedirectoryservice): changed test to be on rename

* chore(resourcedirectoryservice): changed check to be on basedirectoryservice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] Add check for directory and file level operation ordering
2 participants