refactor(mailclient): pass api key explicitly #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
approved these changes
Apr 6, 2022
seaerchin
force-pushed
the
ref/add-di-mailclient
branch
from
24a9e96 to
d13ed96
Compare
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* refactor(mailclient): use di * test(mailclient): update test for new api * refactor(identity): update mailclient init * chore(identity): update error message for mailclient to show on non local dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
see #395 for an associated write-up on the problem.
Closes #395
Solution