Release/0.2.0 #393
Merged
Release/0.2.0 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat: Add Auth service * Feat: add auth router * Feat: add auth endpoints * Feat: convert auth middleware to use dependency injection * feat: add tests for new auth router and service * Fix: add updated auth router endpoints to auth middleware * Refactor: verifyJwt into separate helper method * Nit: add exports for constants * Nit: add helper function for secure and comments for time * Style: early return * Style: test styling * Nit: adjust comments for importing error * Nit: adjust unknown route comment * Nit: return early * Nit: link issue * Refactor: move isSecure to utils * Style: early return * Nit: remove irrelevant comment * Refactor/separate auth initialisation (#377) * Chore: remove unused index router * Refactor: initialise middleware outside of server.js * Refactor: move unknown route check to server.js * Refactor: import auth middleware directly in routers * Chore: remove noverify method
* Feat: add sitesService * Feat: add sites router * Feat: add site endpoints * Tests: add tests * Fix: use pushed_at instead of updated_at * Style: add spacing to tests * Style: object destructuring * Style: return type and map * Fix: return last updated time instead of string representing time and update tests * Feat: throw 404 error if no staging url found * Style: destructuring response * Feat: add access check in github service * Fix: tests * Fix: test comment * Rebase: use auth verify middleware in sites router * Fix: test for config priority
Merged
seaerchin
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Fixes