Refactor/homepage #331
Merged
Refactor/homepage #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
reviewed
Feb 15, 2022
newroutes/homepage.js
Outdated
Comment on lines
40
to
44
| const { error } = UpdateHomepageSchema.validate(req.body, { | ||
| allowUnknown: true, | ||
| }) |
There was a problem hiding this comment.
i think this is a good pattern that we should be using going forward! we validate unknown data and ensure that it's of a valid shape before passing it onto our services!
alexanderleegs
force-pushed
the
refactor/auth
branch
from
bbd8028 to
afb1d07
Compare
alexanderleegs
force-pushed
the
refactor/homepage
branch
from
2610f33 to
830ca4c
Compare
seaerchin
reviewed
Mar 16, 2022
newroutes/homepage.js
Outdated
|
|
||
| router.get( | ||
| "/:siteName/homepage", | ||
| attachReadRouteHandlerWrapper(this.readHomepage) |
There was a problem hiding this comment.
i think once we shift to ts, we can try doing this with decorators to see if it eases the friction!
alexanderleegs
force-pushed
the
refactor/homepage
branch
from
1b04b91 to
c34bedf
Compare
alexanderleegs
force-pushed
the
refactor/homepage
branch
from
e69ff47 to
91fd3cf
Compare
seaerchin
approved these changes
Apr 5, 2022
alexanderleegs
force-pushed
the
refactor/homepage
branch
from
42e416c to
c49a6be
Compare
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat: add updateHomepageSchema * Feat: add homepage router * Fix: allow pageBody for updateHomepage * Test: add tests for homepage router * Nit: line spacing * Chore: add comment for empty string in schema * Nit: fix comment for error type importing * Fix: throw only error.message from joi * Rebase: inject auth middleware verify into router * Nit: rename variable * Fix: allow empty description and notification * Fix: use subrouter for homepage * Fix: test location * Fix: retrieve accessToken from res.locals * Fix: use fixtures and omit in homepage tests * Feat: add read failure to homepage test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the refactored homepage router, in line with our recent refactoring efforts. It builds off the existing HomepagePageService that already exists for use by the SettingsRouter. It also adds the relevant tests for the homepage router component.
The media categories router contains the following endpoints:
GET /:siteName/homepage - Retrieve homepage information
POST /:siteName/homepage- Update homepage information
Notes
I have opted for a looser schema of the updateHomepage request (e.g. not checking all section details), as several sites have additional details in the front matter of their homepage due to legacy issues, though I am open to suggestions on what we could do if we want to enforce a stricter format.