Merge to prod: 14 Oct 2021 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat: add request schema for collection router * Feat: add mover service * Fix: updateOrder to not require sha * Feat: add base directory service * Feat: add collection directory service * Feat: add updateSubcollection method in SubcollectionPageService * Feat: subcollectionDirectoryService * Feat: add collection router * Feat: add v2 router to server * Fix: change const variable in collection directory service * Fix: update auth middleware for new endpoints * Fix: conversion of collection.yml to file object array * Fix: collectionPageService and subcollectionPageService tests This commit fixes an issue in the subcollection page tests for create. We previously expected the same object to be returned in the convertDataToMarkdown function, which would always succeed regardless of the actual value of the third_nav_title parameter in the front matter, since the object itself was modified in the method. * Feat: add test for update subcollection * Fix: change request schema for reorder directory * Fix: tighten check for path in base directory service * Fix: use new method arguments for moverService * Fix: update return of listAllCollections * Fix: only return file name for subcollectionDirectoryService.listFiles * Fix: githubService as dependency for SubcollectionDIrectoryService * Fix: handle placeholder file separately when renaming subdirectory * Fix: populate reqDetails object properly * Feat: add route for moving collection pages * Feat: add unlinked pages directory service * Feat: add unlinked page directory endpoints to unlinked page router This commit also changes the endpoint of unlinked pages to use `/:siteName/pages/pages`, to prevent overlap with the page moving endpoint * Fix: update auth middleware with new routes * Fix: retrieve target collection/subcollectionname from move request body * Fix: import move directory request schema for unlinked page router * Fix: variable name * Fix: add check for protected folder when deleting * Fix: do not change third_nav_title when renaming files * Fix: deslugify subcollection name on creation This commit deslugifies the subcollection name provided by the user on creation - the purpose of this is to remain consistent with the display on the cms vs on the actual site, since we currently have to deslugify the subcollection name when populating the third_nav_title for files on existing subfolders. * Fix: reorder subcollection * Fix: deslugify renamed subcollection * Fix: enforce that items and target are required for reorder and move directory schemas * Chore: install packages * Feat: slugify collection names when creating new collections * fix(services): change response schema for createDirectory services * Feat: change format of git tree request object * Nit: add comment * Nit: edit comment for directory * Feat: add additional validation for subcollection and page creation and renaming * Fix: rename subcollection check * Fix: slugify renamed collection * Fix: add check for invalid file types when renaming subcollection * Fix: modify validation to exclude .md for files * Feat: change titleSpecialCharCheck to use destructured arguments * Chore: move validators file under validators folder * Refactor/collection refactor tests (#283) * Feat: add tests for baseDirectoryService * Feat: add tests for collectionDirectoryService * Feat: add tests for subcollectionDirectoryService * Feat: add tests for unlinkedPagesDirectoryService * Feat: add tests for collections router * Feat: add tests for new routes in unlinked pages router * Feat: add tests for moverService * Feat: add tests for navYmlService * Fix: update schema for creating collection/subcollection in tests * Fix: update baseDirectoryService tests with new git tree format * Feat: add validation tests for names * Feat: add test for slugification when renaming collection * Fix: change file names in tests to include .md * Chore: update test command to use updated env vars Co-authored-by: Alexis <[email protected]>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-PACRESOLVER-1564857
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AXIOS-1579269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Refactor:
Misc: