Fix: prevent truncating of page body #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamkeewei
added a commit
that referenced
this pull request
Nov 8, 2021
* develop: (25 commits) fix: package.json & package-lock.json to reduce vulnerabilities (#285) fix: package.json & package-lock.json to reduce vulnerabilities (#311) Refactor/collection refactor (#281) build(deps-dev): bump jest from 26.6.3 to 27.0.6 (#222) build(deps): bump tmpl from 1.0.4 to 1.0.5 (#304) build(deps): bump axios from 0.21.1 to 0.21.4 (#295) Fix: change git tree object format (#305) Fix: handle 409 errors when editing files (#303) hotfix: properly handle subcollection file update Fix: prevent truncating of page body (#299) Feat: add ability to edit description in settings (#280) ci: remove .ebextensions from zip ci: update backend staging eb env ci: update production eb env name (#298) ci: include .platform dir in deployment chore: specify node version chore: use EB platform hooks instead of ebextensions chore: add health check endpoint chore: use new cicd user creds fix: update ebextension to fix EB deploy ...
lamkeewei
added a commit
that referenced
this pull request
Nov 8, 2021
…token-middleware * feat/identity/database-models: (25 commits) fix: package.json & package-lock.json to reduce vulnerabilities (#285) fix: package.json & package-lock.json to reduce vulnerabilities (#311) Refactor/collection refactor (#281) build(deps-dev): bump jest from 26.6.3 to 27.0.6 (#222) build(deps): bump tmpl from 1.0.4 to 1.0.5 (#304) build(deps): bump axios from 0.21.1 to 0.21.4 (#295) Fix: change git tree object format (#305) Fix: handle 409 errors when editing files (#303) hotfix: properly handle subcollection file update Fix: prevent truncating of page body (#299) Feat: add ability to edit description in settings (#280) ci: remove .ebextensions from zip ci: update backend staging eb env ci: update production eb env name (#298) ci: include .platform dir in deployment chore: specify node version chore: use EB platform hooks instead of ebextensions chore: add health check endpoint chore: use new cicd user creds fix: update ebextension to fix EB deploy ...
lamkeewei
added a commit
that referenced
this pull request
Nov 8, 2021
…/email-login * feat/identity/site-token-middleware: (25 commits) fix: package.json & package-lock.json to reduce vulnerabilities (#285) fix: package.json & package-lock.json to reduce vulnerabilities (#311) Refactor/collection refactor (#281) build(deps-dev): bump jest from 26.6.3 to 27.0.6 (#222) build(deps): bump tmpl from 1.0.4 to 1.0.5 (#304) build(deps): bump axios from 0.21.1 to 0.21.4 (#295) Fix: change git tree object format (#305) Fix: handle 409 errors when editing files (#303) hotfix: properly handle subcollection file update Fix: prevent truncating of page body (#299) Feat: add ability to edit description in settings (#280) ci: remove .ebextensions from zip ci: update backend staging eb env ci: update production eb env name (#298) ci: include .platform dir in deployment chore: specify node version chore: use EB platform hooks instead of ebextensions chore: add health check endpoint chore: use new cicd user creds fix: update ebextension to fix EB deploy ...
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where having
---in the page body would truncate the contents when viewed on the CMS. This was due to our reliance on this string to denote the location of the frontmatter. This PR modifies the check for frontmatter to only search for the first 2 occurrences of this, to prevent this behaviour.