Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(hotfix to master) loosen request schema #276

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

alexanderleegs
Copy link
Contributor

This PR fixes an issue with our existing schema for frontmatter - as we did not specify that unknown keys were allowed, existing pages which had additional parameters (e.g. breadcrumb) could not be modified. This PR fixes this issue by loosening our constraints on the frontmatter accepted.

Copy link
Contributor

@prestonlimlianjie prestonlimlianjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 4e3fbe9 into master Aug 23, 2021
@alexanderleegs alexanderleegs deleted the hotfix/loosen-request-schema branch August 23, 2021 04:36
harishv7 pushed a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants