Blob #26
Merged
Blob #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error is thrown when using `res.render()` in the error handler function. The error returned is `no default engine was specified and no extension was provided`. The solution was to use `res.json()`
A size limit of 1 MB is imposed for the file retrieval from the Github "Contents" API. Usually, the files in the Isomer repo don't hit that size limit except for images where they tend to be bigger than 1MB. To get around this, the blobs API supports file sizes of of up to 100MB.
You can now send json payloads of upto 5mb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow one to retrieve/upload larger images using Git blobs. (#18)
The commit edac009 addresses the retrieving issue.
The commit 54a41a3 addresses the uploading issue.