Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles media folders not found error #175

Merged
merged 1 commit into from
May 12, 2021

Conversation

gweiying
Copy link
Contributor

Currently, if a repo has no images and files folder, a 404 is thrown and the frontend is redirected. This PR catches the 404 and sends an empty directoryContent response to the frontend.

@gweiying gweiying requested a review from alexanderleegs May 12, 2021 05:58
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for the quick fix

@gweiying gweiying merged commit af42723 into develop May 12, 2021
@gweiying gweiying deleted the fix/mediafolder-not-found branch May 12, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants