(hotfix to develop) misc bugs #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
pushed a commit
that referenced
this pull request
Apr 29, 2021
* fix: change base64 encoding * fix: missing content during page move
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* fix: change base64 encoding * fix: missing content during page move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the library used for encoding on the backend, standardising it on the
Base64library. The other library used,base-64does not support encoding foreign language, hence users were experiencing difficulty saving resource files containing foreign language characters, as they were being encoded withbase-64.Error message on backend logs:
Separately, this PR also fixes a bug where page content is not added to files moved to/ out of subfolders, which causes pages to appear blank after moving out of/ to a subfolder.