Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add datadog test action #1449

Merged
merged 4 commits into from
Sep 24, 2024
Merged

chore: add datadog test action #1449

merged 4 commits into from
Sep 24, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

we want to have visibility on our tests on datadog.

Solution

  1. use dd test visibility action to forward to dd
  2. add the action right before the test step as per their docs to avoid interference with the tracers

karrui
karrui reviewed Sep 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@seaerchin seaerchin requested a review from karrui September 24, 2024 05:39
seaerchin and others added 3 commits September 24, 2024 14:08
@seaerchin
chore: update simplegit
9b4f626 
right now, our tests are failing in ci due to the `cwd` call. this might
be due to simple-git's build, so we are attempting to update
@karrui
feat(ci): try injecting datadog environment without action
e040f3f
@karrui
fix(ci): remove redundant env
3f9eedc
@seaerchin seaerchin merged commit 8509ddd into develop Sep 24, 2024
10 of 11 checks passed
@seaerchin seaerchin deleted the chore/dd-tests branch September 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@harishv7 harishv7 Awaiting requested review from harishv7

@alexanderleegs alexanderleegs Awaiting requested review from alexanderleegs

@dcshzj dcshzj Awaiting requested review from dcshzj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @karrui