fix(sitelaunch): do not throw for no dig results

[kishore03109]

Problem

When there was no records that were found, dns:node throws an error. While we did handle it, there should have been an additional return statement to exit early rather than propagating into an error state.

Solution

If the error is of type ENODATA, return early with some default values instead.

Breaking Changes

• Yes - this PR contains breaking changes
  • Details ...
• No - this PR is backwards compatible with ALL of the following feature flags in this doc

Tests

Locally enter these values into support/routes/v2/formsg/index.ts

formsgSiteLaunchRouter
  .digAAAADomainRecords({
    primaryDomainSource: "singaopreoae.sg",
  } as SiteLaunchResult)
  .then(console.log)
  .catch(console.error)

formsgSiteLaunchRouter
  .digCAADomainRecords({
    primaryDomainSource: "singaopreoae.sg",
  } as SiteLaunchResult)
  .then(console.log)
  .catch(console.error)

assert that the console log outputs

Deploy Notes

This fix is meant to go into prod line asap

[kishore03109]

• fix(sitelaunch): do not throw for no dig results #1355 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kishore03109 and the rest of your teammates on Graphite

[kishore03109]

without this return, this ended up throwing an error instead

[kishore03109]

without this return, this ended up throwing an error instead

[timotheeg]

/nit since you're editing this file, you could take the opportunity to clean up the neighbouring log statements. The existing statements does not print the error (since errors are not serializable).

Suggested change

	logger.error(
	`Error when trying to get AAAA records for domain ${launchResult.primaryDomainSource}: ${e}`
	logger.error({
	message: 'Error when trying to get AAAA records for domain',
	error: e,
	meta: {
	domain: launchResult.primaryDomainSource
	}
	})

Same can be done for the other error() and info() logs seen as context code in the PR.

But yeah, so main message with enahnced logging:

• report errors as-is, let the logger figure out how to export it
• log parameters as fields rather than interpolated content in the message

[kishore03109]

since merged will create a separate pr #1358 ya

[timotheeg]

Yes Sir 👍 . Thank you 🙏 .