Fix/whitespace and new line chars #1351
Conversation
| @@ -2,6 +2,26 @@ import yaml from "yaml" | |||
|
|
|||
| import { sanitizer } from "@services/utilServices/Sanitizer" | |||
|
|
|||
| const LINE_BREAK_REGEX = "[\r\n\x0B\x0C\u0085\u2028\u2029]" | |||
There was a problem hiding this comment.
rather than trying to reimplement white space character check, i suggest only caring about new line characters and let String.prototype.trim() handle spaces.
Currently, in the attempt of implementing both, the check for spaces is not as complete as the one implemented for the function call trim.
Do we care about any space here? ie hi there should be hithere?
There was a problem hiding this comment.
Hmm the new line regex is really just to catch the new line characters, and not to replace other whitespace - as far as I can tell these are the specific characters which can be used for new lines. The in between spaces should be preserved
src/utils/yaml-utils.ts
Outdated
| return obj.map((item) => recursiveTrimAndReplaceLineBreaks(item)) | ||
| } | ||
| if (typeof obj === "object" && obj !== null) { | ||
| const newObj: any = {} |
There was a problem hiding this comment.
possible to use some sort of recursive types and avoid the use of any? maybe thr typechecking / recursive types?
There was a problem hiding this comment.
eh i re-requested a review by accident, just ping me on slack once ready
There was a problem hiding this comment.
Fixed in 1e212c8!
This PR fixes issues we have with trailing whitespace and unicode line breaks. See this issue, this issue and this issue for more details.
Concretely, this PR creates a new util method to trim whitespace and replace unicode new line characters with spaces, which is used to parse user provided input for all page/folder/settings create/update endpoints. Note that this means existing folders with a trailing space continue to have their new pages affected until the folder is renamed - this is expected and should be resolved manually as they come up.
Tests