Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.83.0 #1335

Merged
merged 11 commits into from
Apr 26, 2024
Merged

release v0.83.0 #1335

merged 11 commits into from
Apr 26, 2024

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Apr 26, 2024

New

  • ISOM-1006: Optimize verifySiteMember() #1332
  • fix(dep): remove redundant deps #1333
  • chore(growthbook): handle refreshes at module level #1228
  • fix: upgrade aws-sdk from 2.1579.0 to 2.1586.0 #1315
  • fix: upgrade @aws-sdk/client-secrets-manager from 3.533.0 to 3.540.0 #1316
  • fix: upgrade @types/node from 18.19.18 to 18.19.26 #1314
  • fix: upgrade sequelize from 6.35.2 to 6.37.1 #1317
  • fix(snyk): update title #1331
  • Safer pagination and refresh for site cache #1239
  • backport v0.82.0 #1330

Tests

chore(growthbook): handle refreshes at module level #1228

  • Load the cms and verify functionality gated by feature flag still exists (TODO: find a specific feature flag to test on)

ISOM-1006: Optimize verifySiteMember() #1332

The PR is fully backward compatible and transparent, but what it touches is getRole(), so we shoud verify that the flows that use it still work.

The primary one is verifySiteMember(), which is called by all auth points. Run the following 2 tests:

  • Verify you can access the site you are supposed to be able to access
  • Verify you cannot access the sites you are not supposed to be able to access (assuming you are not an isomeradmin)

Deploy Notes

Full Changelog: https://github.com/isomerpages/isomercms-backend/compare/v0.82.0..v0.83.0

alexanderleegs and others added 11 commits April 24, 2024 13:59
* refactor: retrieve repo pages using github's pagination link system

* refactor: clear all references to ISOMERPAGES_REPO_PAGE_COUNT

* refactor: retrieve site's lastUpdated in O(1)

* feat(SiteCache): optimize cache refresh for load distribution rather than time

* fix(SiteCache): fix invalid page number injection 🤦

* feat(SiteCache): instrument renewCache()

* fix(test): update tests

* fix: more test fixes

* fix: reset axios mock properly

* fix: remove hardcoded value (was used for tests)

* fix: add explicit return type

* feat: introduce new type LinkRelation

* refactor: using string.matchAll() instead of RegExp.exec()

* refactor: better use of types
* chore(growthbook): handle refreshes at module level

* chore: update growthbook

* feat: use the new GrowthBook instantiation style
## Problem

We are seeing weird commits like [this](https://github.com/isomerpages/isomercms-backend/pull/1314/files). I previously added them in by mistake, thought i removed it alr but turns out its not. this is a cleanup, doesnt make sense to mark it as both a dep and a dev dep at the same time.

## Solution

![Screenshot 2024-04-25 at 10.55.34 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/ff53f9e5-0bac-4958-a327-65d61d86a168.png)

rm the dep, since its just a dep dep 

**Breaking Changes**

<!-- Does this PR contain any backward incompatible changes? If so, what are they and should there be special considerations for release? -->

- [ ] Yes - this PR contains breaking changes
  - Details ...
- [X] No - this PR is backwards compatible with ALL of the following feature flags in this [doc](https://www.notion.so/opengov/Existing-feature-flags-518ad2cdc325420893a105e88c432be5)
* refactor(getRole): exit early if role is valid

* TEMP: feat: use a more efficient query

* feat: implement optimization 1 and fix tests

* fix: dont use short table aliases in raw query

* fix: be more explicit about matching just one record

* fix: reference to role in sql statement
@alexanderleegs alexanderleegs requested a review from a team April 26, 2024 01:15
@alexanderleegs alexanderleegs mentioned this pull request Apr 26, 2024
@alexanderleegs alexanderleegs merged commit fbbfb58 into master Apr 26, 2024
43 of 44 checks passed
@mergify mergify bot deleted the release_v0.83.0 branch April 26, 2024 01:41
This was referenced Jun 27, 2024
@dcshzj dcshzj mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants