-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v0.83.0 #1335
Merged
Merged
release v0.83.0 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport v0.82.0
* refactor: retrieve repo pages using github's pagination link system * refactor: clear all references to ISOMERPAGES_REPO_PAGE_COUNT * refactor: retrieve site's lastUpdated in O(1) * feat(SiteCache): optimize cache refresh for load distribution rather than time * fix(SiteCache): fix invalid page number injection 🤦 * feat(SiteCache): instrument renewCache() * fix(test): update tests * fix: more test fixes * fix: reset axios mock properly * fix: remove hardcoded value (was used for tests) * fix: add explicit return type * feat: introduce new type LinkRelation * refactor: using string.matchAll() instead of RegExp.exec() * refactor: better use of types
Snyk has created this PR to upgrade sequelize from 6.35.2 to 6.37.1. See this package in npm: https://www.npmjs.com/package/sequelize See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
Snyk has created this PR to upgrade @types/node from 18.19.18 to 18.19.26. See this package in npm: https://www.npmjs.com/package/@types/node See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
…1316) Snyk has created this PR to upgrade @aws-sdk/client-secrets-manager from 3.533.0 to 3.540.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-secrets-manager See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
Snyk has created this PR to upgrade aws-sdk from 2.1579.0 to 2.1586.0. See this package in npm: https://www.npmjs.com/package/aws-sdk See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
* chore(growthbook): handle refreshes at module level * chore: update growthbook * feat: use the new GrowthBook instantiation style
## Problem We are seeing weird commits like [this](https://github.com/isomerpages/isomercms-backend/pull/1314/files). I previously added them in by mistake, thought i removed it alr but turns out its not. this is a cleanup, doesnt make sense to mark it as both a dep and a dev dep at the same time. ## Solution ![Screenshot 2024-04-25 at 10.55.34 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/ff53f9e5-0bac-4958-a327-65d61d86a168.png) rm the dep, since its just a dep dep **Breaking Changes** <!-- Does this PR contain any backward incompatible changes? If so, what are they and should there be special considerations for release? --> - [ ] Yes - this PR contains breaking changes - Details ... - [X] No - this PR is backwards compatible with ALL of the following feature flags in this [doc](https://www.notion.so/opengov/Existing-feature-flags-518ad2cdc325420893a105e88c432be5)
* refactor(getRole): exit early if role is valid * TEMP: feat: use a more efficient query * feat: implement optimization 1 and fix tests * fix: dont use short table aliases in raw query * fix: be more explicit about matching just one record * fix: reference to role in sql statement
Merged
timotheeg
approved these changes
Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
#1332
#1333
#1228
#1315
#1316
#1314
#1317
#1331
#1239
#1330
Tests
chore(growthbook): handle refreshes at module level
#1228
ISOM-1006: Optimize verifySiteMember()
#1332
The PR is fully backward compatible and transparent, but what it touches is
getRole()
, so we shoud verify that the flows that use it still work.The primary one is
verifySiteMember()
, which is called by all auth points. Run the following 2 tests:Deploy Notes
Full Changelog: https://github.com/isomerpages/isomercms-backend/compare/v0.82.0..v0.83.0