Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert log group to isomer-infra #1320

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: revert log group to isomer-infra #1320

merged 1 commit into from
Apr 17, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Apr 17, 2024

Problem

The log group was previously renamed to prod-support/ecs/dd-agent and stg-support/ecs/dd-agent for prod and staging respectively, but these log groups were not yet created via Pulumi, causing the deployments for the support service to fail.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Bug Fixes:

  • Temporarily revert the log group back to the old log group (which already existed) until the new log group is correctly created on isomer-infra.

Tests

Deploy Notes

None

@dcshzj dcshzj requested a review from a team April 17, 2024 06:43
@dcshzj dcshzj merged commit 058c394 into develop Apr 17, 2024
19 checks passed
@mergify mergify bot deleted the fix/revert-log-group branch April 17, 2024 07:29
@dcshzj dcshzj mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @alexanderleegs