fix: fix comments #1300
Closed
fix: fix comments #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
commented
Apr 13, 2024
| @@ -166,13 +166,13 @@ class UsersService { | |||
| const whitelistDomains = whitelistEntries.map((entry) => entry.email) | |||
| const hasMatchDomain = | |||
| whitelistDomains.filter((domain) => { | |||
| // if domain is really just a domain (does not include a @ OR starts with a @), we can do a prefix match | |||
| // if domain is really just a domain (does not include a @ OR starts with a @), we can do a suffix match | |||
| if (/^@|^[^@]+$/.test(domain)) { | |||
There was a problem hiding this comment.
Not related to this PR, but we could flip the condition to use a simpler regexp (didn't think of it during incident yesterday 😑🤦)
// if domain a full email address (it has content before the @), we can ONLY do exact match on it
if (/^.+@/.test(domain)) {
return normalizedEmail === domain
}
// otherwise we can do a suffix match
return normalizedEmail.endsWith(domain)
|
Closing PR. Superseeded by #1301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Incorrect comment says
prefix, when it should saysuffix🤦Solution
Fix comment