fix: off-by-one error for month number #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
approved these changes
Apr 12, 2024
This was referenced Apr 15, 2024
Closed
Closed
Closed
Merged
seaerchin
added a commit
that referenced
this pull request
Apr 15, 2024
* fix: off-by-one error for month number (#1294) * ref(app): shift support flows into separate folder + ecs service (#1269) * feat(caddyfile): add initial caddyfile * refactor(infra): shift infra stuff to new folder * chore(formsg): shift stuff into sub folder * refactor(server): shift infra stuff out * refactor(common): shift shared stuff into common folder * build(package/tsconfig): update packages + paths * refactor(server): swap to ts * refactor(request): update type * feat(infra/routes): add new router * refactor(router): shift initialisation in * refactor(middleware): shift shared stuff out * chore(exports): add exports from indexs * chore(featureflag): disable single export * feat(docker): add containers in docker-compose for infra * feat(deploy): update deploy stuff * chore(cleanup): remove unused/extra code in infra/server * fix(aws_deploy): update deploy file * fix(task def): removed portmappings * fix(dockerfile): copy src files over * fix(docker): update port mappings as ecs uses same network * fix(caddy): update to use local dockerfile * fix(caddyfile): upate proxies * fix(caddyfile): try to netweork via loopback * revert(aws_deploy): revert previous changes * revert(deploy_staging): revert * revert(task def): revert be task def * revert(src): revert files that were used for sidecar * refactor(support): shift into new container * fix(docker): update dockerfile + add health check * fix(aws_deploy): update tag * refactor(index): remove unsnued * fix(app spec): do replacement for container name and port * fix(ci): update image names * feat(support): connect db * chore(request): remove unused import * refactor(dockerfile): update to explicitly copy * chore(index): add a line space * refactor(support task def): update so that dd-service is `isomer-support` and team is isomer * chore(formsg tests): shift tests from `src` -> `support` * ci(sidecar): add deploy files for prod (#1285) * feat(deploy_prod): update workflow to include deploy_support * feat(support-task-def): add prod * fix(task def): update dd tags to include service * fix(dockerfile): revert to copy . (#1304) * chore: bump version to v0.79.0 --------- Co-authored-by: Harish <[email protected]> Co-authored-by: Hsu Zhong Jun <[email protected]> Co-authored-by: Timothee Groleau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The month number has an off-by-one error as it is zero-indexed, which means for April,
getMonth()will return3instead of4.Solution
Breaking Changes
Bug Fixes:
2024-02-31is not being produced erroneously).Tests
Deploy Notes
None