Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergify): fix copy/paste mistake #1280

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(mergify): fix copy/paste mistake #1280

merged 1 commit into from
Apr 9, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

merged previous mergify PR but managed to paste wrongly -> this resulted in all non sem-ver minor PRs up being merged.

this is

  1. PR for base-64 (we don't use this - maybe can remove)
  2. PR for marked -> we do use this! however, the change is to update marked to conform to changes in the markdown spec (to resolve ambiguity...)

Solution

  • change rule from minor -> major
  • looked at marked's 12.0 update here; ss attached below for convenience; as most of the changes are helpful to us (we only call marked.parse), i'm not going to rollback the PR
Screenshot 2024-04-08 at 11 00 17 PM

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details
    • added env var to 1PW + SSM script (fetch_ssm_parameters.sh)

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@seaerchin seaerchin requested a review from a team April 8, 2024 15:01
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor clarification

.github/mergify.yml Show resolved Hide resolved
@seaerchin seaerchin merged commit d493d4e into develop Apr 9, 2024
20 checks passed
@seaerchin seaerchin deleted the fix/mergify branch April 9, 2024 02:26
@harishv7 harishv7 mentioned this pull request Apr 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants