fix: name auth routers #1278
Merged
fix: name auth routers #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
lgtm; i checked this by just going into the v2 routers and searching for arrow functions, which don't have a this binding (and hence, no name).
i think v2/authenticated/metrics.ts was missing this but there's only 1 method, collateUserFeedback so maybe we just want to change it to a named function and merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Auth middlewares are not named correctly:
Example trace:
Trace link for reference
Solution
Use the method namer introduced in this PR