fix(navbar): allow ext links #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kishore03109 and the rest of your teammates on |
seaerchin
approved these changes
Mar 28, 2024
timotheeg
approved these changes
Mar 28, 2024
kishore03109
force-pushed
the
03-28-fix_navbar_allow_ext_links
branch
from
acd1869 to
5b7d6d8
Compare
kishore03109
force-pushed
the
03-28-fix_navbar_allow_ext_links
branch
from
5b7d6d8 to
6411595
Compare
seaerchin
reviewed
Apr 1, 2024
There was a problem hiding this comment.
@alexanderleegs - can you check and see what keys need to be added for bcakwards compat
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently we have some agencies that use external links for their navbar. this brings back the backward compat with those agencies.
for more context, refer here
@seaerchin am adding another key, looks ugly but is affecting prod sites as of right now. let me know if you have concerns regarding this