fix(dig): dig not working

[kishore03109]

Problem

We do have some checks in the backend to check prior to any site launch that there are AAAA records/CAA records present. In this case, the dig commands to check the AAAA records failed.

The reason for above is that we were using a library called node-dig-dns. This called the dig command directly at a system level. However, our docker container does not have the dig command out of the box. This resulted in the existence of AAAA records not being caught.

We are also codifying a check for CAA records and ensuring that if there exist at least one caa record and it uses our redirection service, it should have letsencrypt as one of the caa record.

To prevent accidental commits to live indirection repo during dev, also adding a check to only commit to the indirection repository iff it is in prod environment.

Solution

just use node's dns resolver directly. this way we dont have to depend on an external library's implementation of node and dont have to install unnecessary deps in the docker.

remove dep introduced in #1244

Breaking Changes

• Yes - this PR contains breaking changes
  • Details ...
• No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

Manual test (not to be copied over to deployment notes)

• add these lines of code at the end of server.js

const formResponses = [
  {
    submissionId: "",
    requesterEmail: "[email protected]",
    repoName: "kishore-test-dev-emil",
    primaryDomain: "google.com",
    redirectionDomain: "www.google.com",
    agencyEmail: "[email protected]",
  },
]

formsgSiteLaunchRouter.handleSiteLaunchResults(formResponses, "test")

• Assert that the email comes out to

[kishore03109]

• fix(dig): dig not working #1246 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kishore03109 and the rest of your teammates on Graphite

[seaerchin]

since we're removing the external dependency here, should we also update the dockerfile to remove the installation of bind-tools?

[seaerchin]

could we change the any? separately, why are we not logging the error here? should it be info or should we set to warn?

[kishore03109]

added type guard 5e7d5e9

[seaerchin]

ssee above comment

[kishore03109]

5e7d5e9

[seaerchin]

lgtm, just accept suggestion to remove any

[seaerchin]

Suggested change

	export function isErrnoException(obj: any): obj is NodeJS.ErrnoException {
	return (
	obj &&
	(typeof obj.errno === "number" || obj.errno === undefined) &&
	(typeof obj.code === "string" || obj.code === undefined) &&
	(typeof obj.path === "string" || obj.path === undefined) &&
	(typeof obj.syscall === "string" || obj.syscall === undefined)
	)
	}
	export function isErrnoException(obj: unknown): obj is NodeJS.ErrnoException {
	const err = obj as NodeJS.ErrnoException
	return (
	err &&
	(typeof err.errno === "number" || err.errno === undefined) &&
	(typeof err.code === "string" || err.code === undefined) &&
	(typeof err.path === "string" || err.path === undefined) &&
	(typeof err.syscall === "string" || err.syscall === undefined)
	)
	}