feat(dd): add traces to gitfilesysteM #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kishore03109 and the rest of your teammates on |
kishore03109
force-pushed
the
03-25-feat_dd_add_traces_to_gitfilesysteM
branch
7 times, most recently
from
f347e5d to
82171bb
Compare
timotheeg
force-pushed
the
03-25-feat_dd_add_traces_to_gitfilesysteM
branch
3 times, most recently
from
e64fdcb to
bf3e618
Compare
|
|
Test on staging with dd-trace V5, sample trace here for reference |
timotheeg
approved these changes
Mar 27, 2024
|
@timotheeg @kishore03109 we seem to have git patches here? not sure if this was intended |
It's intended. We have to patch |
|
seaerchin
reviewed
Mar 27, 2024
kishore03109
force-pushed
the
03-25-feat_dd_add_traces_to_gitfilesysteM
branch
from
89be271 to
69fa04b
Compare
kishore03109
added a commit
that referenced
this pull request
Mar 28, 2024
* chore(package): use npm (#1237) * fix: upgrade dotenv from 16.4.1 to 16.4.5 (#1233) Snyk has created this PR to upgrade dotenv from 16.4.1 to 16.4.5. See this package in npm: https://www.npmjs.com/package/dotenv See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * build(deps): bump express from 4.17.3 to 4.19.2 (#1242) Bumps [express](https://github.com/expressjs/express) from 4.17.3 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.3...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: package.json & package-lock.json to reduce vulnerabilities (#1241) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-EXPRESS-6474509 Co-authored-by: snyk-bot <[email protected]> * fix: upgrade @growthbook/growthbook from 0.27.0 to 0.34.0 (#1232) Snyk has created this PR to upgrade @growthbook/growthbook from 0.27.0 to 0.34.0. See this package in npm: https://www.npmjs.com/package/@growthbook/growthbook See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * fix: upgrade @aws-sdk/client-dynamodb from 3.501.0 to 3.521.0 (#1229) Snyk has created this PR to upgrade @aws-sdk/client-dynamodb from 3.501.0 to 3.521.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-dynamodb See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * fix: upgrade @aws-sdk/client-amplify from 3.501.0 to 3.521.0 (#1230) Snyk has created this PR to upgrade @aws-sdk/client-amplify from 3.501.0 to 3.521.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-amplify See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * fix: upgrade @aws-sdk/client-cloudwatch-logs from 3.501.0 to 3.521.0 (#1231) Snyk has created this PR to upgrade @aws-sdk/client-cloudwatch-logs from 3.501.0 to 3.521.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-cloudwatch-logs See this project in Snyk: https://app.snyk.io/org/isomer/project/676b9e26-cebf-4964-b7b3-d9843e3339ff?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> * fix(dockerfile): add dig to image (#1244) * feat(dd): add traces to gitfilesysteM (#1240) * feat(dd): adding in metrics to gitfilesystem * feat: instrument with wrap-tracers * feat: patch dd-trace to understand neverthrow * fix: missing tracer import * fix: use the clear tracer.wrap() method * fix(dd): fix patch type * chore: add tests for tracer compatibility with neverthrow * chore: upgrade dd-trace to v5 and patch for neverthrow * chore: remove unecessary change from patch * feat: implement a blacklist for methods that should not be instrumented * chore: remove obsolete patch * chore: lock dd-trace to 5.9.0 strictly so patch is always applied --------- Co-authored-by: Timothee Groleau <[email protected]> * fix: reduce log size to just last commit (#1243) * fix: reduce log size to just last commit * feat: defaults maxCount in getGitLog to 1 * chore(GitFileSystemService): add validation tests for getGitLog * chore(dep): add flag (#1247) * chore: bump version to v0.73.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: seaerchin <[email protected]> Co-authored-by: Isomer Admin <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timothee Groleau <[email protected]> Co-authored-by: Timothee Groleau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we are having divergence, still not enough information to determine why. adding traces to the major gitfile system operations to give a better idea of what is happening.
Notes to all dev
Once this PR is merged all devs will need to call npm install to:
Deploy Notes
This PR records a lot of new spans into traces. Basically ALL
GitFileSystemoperations are now instrumented.During release, close attention need to be given to system load to ensure the new instrumentation is not adding too high a CPU cost to the system.