fix(tracer): fix tag setting on span #1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we were setting the tags for the trace as a bootstrap process. this means that the
tracer.init
call does not bootstrap properly (astracer.use
is meant to be called at start-up, prior to actual tracing).this PR changes it so that the tags are set on the span.
Solution
tracer.use
, which is a bootstrap call, change to get the active span and callingsetTag
on that span.Tests