Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otp): unwrap ResultAsync value #1204

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Mar 11, 2024

Problem

Closes [insert issue #]

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details
    • added env var to 1PW + SSM script (fetch_ssm_parameters.sh)

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@dcshzj dcshzj requested a review from a team March 11, 2024 11:19
@dcshzj dcshzj merged commit a66c503 into develop Mar 11, 2024
10 of 13 checks passed
@mergify mergify bot deleted the fix/unwrap-resultasync-value branch March 11, 2024 11:19
This was referenced Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants