Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): ensure gitconfig is stored in the right place #1178

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(docker): ensure gitconfig is stored in the right place #1178

merged 1 commit into from
Mar 1, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Feb 29, 2024

Problem

The .gitconfig file is still being stored in root despite the application being run as webapp.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Bug Fixes:

  • Fixed the location where the .gitconfig file is being stored at, to now store in the webapp user's home directory.

Tests

  • Navigate to any site using the ECS backend
  • Make an edit on the site
  • Ensure that the commit made on the site is by Isomer Admin and not Linux User

Deploy Notes

None

@dcshzj dcshzj requested a review from a team February 29, 2024 06:24
@dcshzj dcshzj merged commit d996b4b into develop Mar 1, 2024
19 checks passed
@mergify mergify bot deleted the fix/proper-git-config branch March 1, 2024 03:20
@alexanderleegs alexanderleegs mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcshzj @harishv7 @alexanderleegs