Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repoChecker): unintended alarms #1176

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix(repoChecker): unintended alarms #1176

merged 2 commits into from
Feb 29, 2024

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Feb 29, 2024

Problem

due to logging of the simple git operation, this triggered other alarms. since this is not a critical flow, fail silently.

also, running the check using the form in parallel to reduce the number of errors that has occured (when i tried running this in prod yesterday, the git.lock file kept perventing the commits from occuring. this is a problem since the form was used for observability, and this would lead to the reports not being committed to remote)

Tests

Screenshot 2024-02-29 at 8 59 26 AM

  • once in staging, use the form to run the checker on multiple repos in efs
  • notice the lack of "SiteCheckerError" AND the lack of "failed to push some refs". this is important as to not create alarms

Copy link

mergify bot commented Feb 29, 2024

⚠️ The sha of the head commit of this PR conflicts with #1177. Mergify cannot evaluate rules on this PR. ⚠️

@kishore03109 kishore03109 merged commit 0a77aa7 into master Feb 29, 2024
28 checks passed
@mergify mergify bot deleted the hotfix/0.68.1 branch February 29, 2024 01:15
@alexanderleegs alexanderleegs restored the hotfix/0.68.1 branch March 5, 2024 07:11
@alexanderleegs alexanderleegs deleted the hotfix/0.68.1 branch March 5, 2024 07:13
@alexanderleegs alexanderleegs mentioned this pull request Mar 7, 2024
This was referenced Jun 27, 2024
@dcshzj dcshzj mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants