-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/lock repos when repairing #1149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
approved these changes
Feb 22, 2024
src/utils/mutex-utils.js
Outdated
@@ -35,10 +35,10 @@ const mockUnlock = (siteName) => { | |||
mockMutexObj[siteName] = false | |||
} | |||
|
|||
const lock = async (siteName) => { | |||
const lock = async (siteName, lockLengthSeconds = 60) => { | |||
try { | |||
const ONE_MIN_FROM_CURR_DATE_IN_SECONDS_FROM_EPOCH_TIME = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the "one min" isn't true anymore, might want to rename the variable to avoid confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0cc6344!
alexanderleegs
added a commit
that referenced
this pull request
Feb 22, 2024
This reverts commit e911e2e.
Merged
alexanderleegs
added a commit
that referenced
this pull request
Feb 29, 2024
This reverts commit a746288.
alexanderleegs
added a commit
that referenced
this pull request
Mar 7, 2024
This reverts commit a746288.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR locks the repo during the time site repair is being done, to prevent editing by users during this period.