Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-prod): add step to ci.yml to deploy to production #1134

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

We have no workflow that deploys to production now. We require a new workflow to push to both ecs and eb (so that deployment for be consistent across both)

Solution

Add a new deploy_prod workflow that does the deploy to ecs/ecr

update ci.yml so that it uses a new job to run the above workflow. we do this instead of just invoking hte new workflow directly cos they have the same trigger (push) so it might fail if both ci + deploy_prod ran tgt

@seaerchin seaerchin requested a review from a team February 19, 2024 05:25
@alexanderleegs alexanderleegs changed the base branch from feat/vapt to develop February 19, 2024 10:11
@seaerchin seaerchin merged commit f936d49 into develop Feb 19, 2024
9 checks passed
@seaerchin seaerchin deleted the feat/deploy-prod branch February 19, 2024 10:14
@alexanderleegs alexanderleegs mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants