fix(betterUptime): make better uptime on success #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
force-pushed
the
feat/betterUptimeOnSuccess
branch
from
a0358e3 to
2cae2db
Compare
There was a problem hiding this comment.
We're still attempting to create the monitor in lines 310-311
( // Create better uptime monitor await this.createMonitor(launchResult.value.primaryDomainSource))
,
this should be removed right!
There was a problem hiding this comment.
ps forgot to remove
alexanderleegs
pushed a commit
that referenced
this pull request
Jan 4, 2024
* fix(betterUptime): make better uptime on success * fix(betteruptime): only create alarm iff success * fix(formsgsl): rm redundant call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently our better uptime is done on create, but it should be on success instead.
Closes [insert issue #]
Solution
shifting the creation of this to post success, not during the launch process.
Breaking Changes
Tests