Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove extra and unused submodules #1031

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: remove extra and unused submodules #1031

merged 1 commit into from
Nov 16, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Nov 14, 2023 •
edited
Loading

Problem

There are some extra submodules that are not used in the codebase.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Improvements:

  • The extra submodules have been removed.

Tests

Chore work, no tests.

Deploy Notes

None

@dcshzj dcshzj requested a review from a team November 14, 2023 02:15
kishore03109
kishore03109 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@kishore03109 kishore03109 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry i didnt realise this was was added :sadge:

@dcshzj dcshzj merged commit 1ac8f0f into develop Nov 16, 2023
16 checks passed
@mergify mergify bot deleted the chore/remove-extra-submodules branch November 16, 2023 01:58
This was referenced Nov 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @kishore03109