Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(v1): completely nuke v1 endpoints and associated classes #1018

Merged
merged 1 commit into from
Dec 12, 2023
Merged

refactor(v1): completely nuke v1 endpoints and associated classes #1018

merged 1 commit into from
Dec 12, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Nov 6, 2023

Note: This change has medium risks and requires extensive testing to ensure no breakages

Problem

The v1 API endpoints are no longer used.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Improvements:

  • All v1 endpoints and their associated classes have been removed, marking the end of an era.

Tests

Unit tests, e2e tests on frontend.

Deploy Notes

None

@dcshzj dcshzj requested a review from a team November 6, 2023 07:45
kishore03109
kishore03109 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@kishore03109 kishore03109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wah this is skimmed because I assume this is removal of all v1 points that was already remvoed.

HIGHLY worried about bugs, I think this makes e2e a must + potential QA, thoughts?

@dcshzj dcshzj force-pushed the ref/nuke-v1-endpoints branch from 92da8e0 to a965bc8 Compare November 29, 2023 07:49
@dcshzj dcshzj force-pushed the ref/nuke-v1-endpoints branch from a965bc8 to 0ea8f2e Compare December 11, 2023 06:10
@dcshzj dcshzj force-pushed the ref/nuke-v1-endpoints branch from 0ea8f2e to 7e5d8d7 Compare December 12, 2023 08:09
@dcshzj dcshzj merged commit 9b0d80f into develop Dec 12, 2023
10 checks passed
@mergify mergify bot deleted the ref/nuke-v1-endpoints branch December 12, 2023 08:15
This was referenced Dec 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @kishore03109