Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rr): capture file extensions that are in uppercase #1016

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Nov 3, 2023

Problem

Our logs get a lot of false-positives that files are missing, but that is because our ALLOWED_FILE_EXTENSIONS does not take into account upper-case.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Bug Fixes:

  • Allow ReviewRequestService to check for the upper-case versions as well, and handle them as a proper image.
    • NOTE: We are not allowing end-users to upload images with upper-case file extensions. This change is just to add support for backward compatibility.

Tests

  • Go to sla-geoworks site on CMS (ensure you have it cloned locally on your own GGS)
  • Check that the logs do not throw any errors regarding being unable to get the Git blob hash for uppercase file extensions.

Deploy Notes

None

@dcshzj dcshzj requested a review from a team November 3, 2023 04:24
@dcshzj dcshzj merged commit 4c3b349 into develop Nov 3, 2023
14 checks passed
@mergify mergify bot deleted the fix/expand-file-extensions branch November 3, 2023 05:24
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants