chore: upgrade axios (#1100)

* chore: upgrade packages

* fix: types for axios

* chore: fix tests

package.json

@@ -37,7 +37,7 @@
     "auto-bind": "^4.0.0",
     "aws-lambda": "^1.0.7",
     "aws-sdk": "^2.1428.0",
-    "axios": "~0.27.2",
+    "axios": "^1.6.5",
     "axios-cache-interceptor": "^0.10.7",
     "base-64": "^0.1.0",
     "bcryptjs": "^2.4.3",

src/middleware/__tests__/errorHandler.spec.ts

@@ -1,4 +1,4 @@
-import { AxiosError } from "axios"
+import { AxiosError, AxiosRequestHeaders } from "axios"
 import _ from "lodash"
 import { serializeError } from "serialize-error"
 
@@ -21,7 +21,9 @@ const mockRes = {
 }
 const mockNext = jest.fn()
 const mockAxiosError: AxiosError = {
-  config: {},
+  config: {
+    headers: ({} as unknown) as AxiosRequestHeaders,
+  },
   request: {},
   isAxiosError: true,
   toJSON: jest.fn().mockReturnThis(),

src/services/api/AxiosInstance.ts

@@ -1,5 +1,5 @@
-import axios, { AxiosRequestConfig, AxiosResponse } from "axios"
-import { setupCache } from "axios-cache-interceptor"
+import axios, { AxiosRequestConfig } from "axios"
+import { CacheAxiosResponse, setupCache } from "axios-cache-interceptor"
 import _ from "lodash"
 
 import { config } from "@config/config"
@@ -91,13 +91,13 @@ const requestFormatter = async (axiosConfig: AxiosRequestConfig) => {
   }
 }
 
-const respHandler = (response: AxiosResponse) => {
+const respHandler = (response: CacheAxiosResponse) => {
   // Any status code that lie within the range of 2xx will cause this function to trigger
   tokenServiceInstance.onResponse(response)
   return response
 }
 
-const githubApiInterceptor = (resp: AxiosResponse) => {
+const githubApiInterceptor = (resp: CacheAxiosResponse) => {
   const fullUrl = `${resp.config.baseURL || ""}${resp.config.url || ""}`
   if (
     resp.status !== 304 &&
@@ -126,7 +126,11 @@ isomerRepoAxiosInstance.interceptors.request.use(requestFormatter)
 isomerRepoAxiosInstance.interceptors.response.use(respHandler)
 isomerRepoAxiosInstance.interceptors.response.use(githubApiInterceptor)
 
-const genericGitHubAxiosInstance = axios.create()
+const genericGitHubAxiosInstance = setupCache(axios.create(), {
+  interpretHeader: true,
+  etag: true,
+  headerInterpreter: customHeaderInterpreter,
+})
 genericGitHubAxiosInstance.interceptors.request.use(requestFormatter)
 genericGitHubAxiosInstance.interceptors.response.use(respHandler)
 genericGitHubAxiosInstance.interceptors.response.use(githubApiInterceptor)

src/services/db/__tests__/TokenService.spec.ts

@@ -1,5 +1,5 @@
 import { expect, jest } from "@jest/globals"
-import { AxiosResponse } from "axios"
+import { AxiosRequestHeaders, AxiosResponse } from "axios"
 import { ok, err } from "neverthrow"
 import { ModelStatic } from "sequelize"
 
@@ -594,9 +594,9 @@ describe("Token Service", () => {
       (resetTime: number) =>
         ({
           config: {
-            headers: {
+            headers: ({
               Authorization: `token ${sampleGithubToken}`,
-            },
+            } as unknown) as AxiosRequestHeaders,
           },
           headers: {
             [GITHUB_TOKEN_REMAINING_HEADER]: "1234",