Merge pull request #1023 from isomerpages/release/0.53.0

0.53.0
isomerpages · Nov 9, 2023 · afd4ac3 · afd4ac3
2 parents cf18014 + 392b761
commit afd4ac3
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,8 +4,17 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v0.53.0](https://github.com/isomerpages/isomercms-backend/compare/v0.52.0...v0.53.0)
+
+- fix(mediafileservice): disable sneky cloudmersive [`#1025`](https://github.com/isomerpages/isomercms-backend/pull/1025)
+- fix(file ext): fix casing + better logging [`#1020`](https://github.com/isomerpages/isomercms-backend/pull/1020)
+- fix(rr): capture file extensions that are in uppercase [`#1016`](https://github.com/isomerpages/isomercms-backend/pull/1016)
+- release(0.52.0): merge to develop [`#1012`](https://github.com/isomerpages/isomercms-backend/pull/1012)
+
 #### [v0.52.0](https://github.com/isomerpages/isomercms-backend/compare/v0.51.0...v0.52.0)
 
+> 2 November 2023
+
 - Feat/stagingBuildTimes [`#1008`](https://github.com/isomerpages/isomercms-backend/pull/1008)
 - Fix/quickie/dbUpdate [`#1007`](https://github.com/isomerpages/isomercms-backend/pull/1007)
 - fix(githubCOmmitService): add sane defaults [`#1010`](https://github.com/isomerpages/isomercms-backend/pull/1010)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "isomercms",
-  "version": "0.52.0",
+  "version": "0.53.0",
   "private": true,
   "scripts": {
     "build": "tsc -p tsconfig.build.json",

diff --git a/src/services/db/GitFileSystemService.ts b/src/services/db/GitFileSystemService.ts
@@ -811,8 +811,10 @@ export default class GitFileSystemService {
   }
 
   getMimeType(fileExtension: string): Result<string, MediaTypeError> {
-    if (!ALLOWED_FILE_EXTENSIONS.includes(fileExtension)) {
-      return err(new MediaTypeError("Unsupported file extension found"))
+    if (!ALLOWED_FILE_EXTENSIONS.includes(fileExtension.toLowerCase())) {
+      return err(
+        new MediaTypeError(`Unsupported file extension: ${fileExtension} found`)
+      )
     }
     switch (fileExtension) {
       case "svg":

diff --git a/src/services/fileServices/MdPageServices/MediaFileService.js b/src/services/fileServices/MdPageServices/MediaFileService.js
@@ -32,11 +32,12 @@ class MediaFileService {
     const fileBuffer = Buffer.from(fileContent, "base64")
 
     // Scan file for virus - cloudmersive API
-    const virusScanRes = await scanFileForVirus(fileBuffer)
-    logger.info(`File scan result: ${virusScanRes.CleanResult}`)
-    if (!virusScanRes || !virusScanRes.CleanResult) {
-      throw new BadRequestError("File did not pass virus scan")
-    }
+    // TODO: Evaluate if we still
+    // const virusScanRes = await scanFileForVirus(fileBuffer)
+    // logger.info(`File scan result: ${virusScanRes.CleanResult}`)
+    // if (!virusScanRes || !virusScanRes.CleanResult) {
+    //   throw new BadRequestError("File did not pass virus scan")
+    // }
 
     // Sanitize and validate file
     const sanitizedContent = await validateAndSanitizeFileUpload(content)

diff --git a/src/services/review/ReviewRequestService.ts b/src/services/review/ReviewRequestService.ts
@@ -252,7 +252,7 @@ export default class ReviewRequestService {
     path,
   }: PathInfo): Result<EditedMediaDto, PageParseError> => {
     const fileExt = getFileExt(name)
-    if (ALLOWED_FILE_EXTENSIONS.includes(fileExt)) {
+    if (ALLOWED_FILE_EXTENSIONS.includes(fileExt.toLowerCase())) {
       return ok({
         name,
         path: path.unwrapOr([""]),