fix: remove unecessary join and site retrieval (#1268)

isomerpages · Apr 4, 2024 · a453b9f · a453b9f
1 parent 3fe0734
commit a453b9f
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/src/services/identity/NotificationsService.ts b/src/services/identity/NotificationsService.ts
@@ -228,23 +228,14 @@ class NotificationsService {
     const recentTargetNotification = await this.repository.findOne({
       where: {
         user_id: siteMember.userId,
+        site_id: siteMember.siteId,
         type: notificationType,
         created_at: {
           [Op.gte]: getNotificationExpiryDate(notificationType),
         },
         link,
         source_username: notificationSourceUsername,
       },
-      include: [
-        {
-          model: Site,
-          as: "site",
-          required: true,
-          where: {
-            id: siteMember.siteId,
-          },
-        },
-      ],
     })
 
     if (recentTargetNotification) {