Style: return type and map

isomerpages · Mar 14, 2022 · 9b05ff7 · 9b05ff7
1 parent 63cc4d9
commit 9b05ff7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/newroutes/sites.js b/newroutes/sites.js
@@ -31,7 +31,7 @@ class SitesRouter {
       },
       { userId }
     )
-    return res.status(200).send("OK")
+    return res.status(200)
   }
 
   async getLastUpdated(req, res) {

diff --git a/services/utilServices/SitesService.js b/services/utilServices/SitesService.js
@@ -2,7 +2,6 @@ const axios = require("axios")
 const Bluebird = require("bluebird")
 const _ = require("lodash")
 
-// Import error
 const GH_MAX_REPO_COUNT = 100
 const ISOMERPAGES_REPO_PAGE_COUNT = process.env.ISOMERPAGES_REPO_PAGE_COUNT || 3
 const ISOMER_GITHUB_ORG_NAME = process.env.GITHUB_ORG_NAME
@@ -50,14 +49,13 @@ class SitesService {
     const endpoint = `https://api.github.com/orgs/${ISOMER_GITHUB_ORG_NAME}/repos`
 
     // Simultaneously retrieve all isomerpages repos
-    const paramsArr = []
-    for (let i = 0; i < ISOMERPAGES_REPO_PAGE_COUNT; i += 1) {
-      paramsArr.push({
+    const paramsArr = _.fill(Array(ISOMERPAGES_REPO_PAGE_COUNT), null).map(
+      (_, idx) => ({
         per_page: GH_MAX_REPO_COUNT,
         sort: "full_name",
-        page: i + 1,
+        page: idx + 1,
       })
-    }
+    )
 
     const sites = await Bluebird.map(paramsArr, async (params) => {
       const resp = await axios.get(endpoint, {
@@ -91,8 +89,7 @@ class SitesService {
         )
     })
 
-    const flattenedSites = _.flatten(sites)
-    return flattenedSites
+    return _.flatten(sites)
   }
 
   async checkHasAccess(reqDetails, { userId }) {