fix: hide contactNumber (#584)

isomerpages · Mar 7, 2023 · 8f64c71 · 8f64c71
1 parent 99d2fd9
commit 8f64c71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/fixtures/identity.ts b/src/fixtures/identity.ts
@@ -38,7 +38,6 @@ export const mockCollaboratorContributor1: Attributes<User> & {
   id: 1,
   email: MOCK_IDENTITY_EMAIL_ONE,
   githubId: "test1",
-  contactNumber: "12331231",
   lastLoggedIn: new Date("2022-07-30T07:41:09.661Z"),
   createdAt: new Date("2022-04-04T07:25:41.013Z"),
   updatedAt: new Date("2022-07-30T07:41:09.662Z"),
@@ -59,7 +58,6 @@ export const mockCollaboratorAdmin1: Attributes<User> & {
   id: 2,
   email: MOCK_IDENTITY_EMAIL_TWO,
   githubId: "test2",
-  contactNumber: "12331232",
   lastLoggedIn: new Date("2022-07-30T07:41:09.661Z"),
   createdAt: new Date("2022-04-04T07:25:41.013Z"),
   updatedAt: new Date("2022-07-30T07:41:09.662Z"),
@@ -79,7 +77,6 @@ export const mockCollaboratorAdmin2: Attributes<User> & {
   id: 3,
   email: MOCK_IDENTITY_EMAIL_THREE,
   githubId: "test3",
-  contactNumber: "12331233",
   lastLoggedIn: new Date("2022-06-30T07:41:09.661Z"),
   createdAt: new Date("2022-04-04T07:25:41.013Z"),
   updatedAt: new Date("2022-07-30T07:41:09.662Z"),
@@ -99,7 +96,6 @@ export const mockCollaboratorContributor2: Attributes<User> & {
   id: 4,
   email: MOCK_IDENTITY_EMAIL_FOUR,
   githubId: "test4",
-  contactNumber: "12331234",
   lastLoggedIn: new Date("2022-07-30T07:41:09.661Z"),
   createdAt: new Date("2022-04-04T07:25:41.013Z"),
   updatedAt: new Date("2022-07-30T07:41:09.662Z"),

diff --git a/src/services/identity/CollaboratorsService.ts b/src/services/identity/CollaboratorsService.ts
@@ -90,6 +90,10 @@ class CollaboratorsService {
         {
           model: User,
           as: "site_members",
+          attributes: {
+            // Hide PII such as contactNumber
+            exclude: ["contactNumber"],
+          },
         },
         {
           model: Repo,