Fix/wrap reviewer mail in try catch (#1136)

* fix: wrap send reviewer mail in try catch * chore: add comment
isomerpages · Feb 19, 2024 · 763aca9 · 763aca9
1 parent 2e3f1b4
commit 763aca9
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/services/review/ReviewRequestService.ts b/src/services/review/ReviewRequestService.ts
@@ -374,7 +374,14 @@ export default class ReviewRequestService {
           // Should not reach here
           throw new Error(`Reviewer with id ${id} has no email`)
         }
-        await this.mailer.sendMail(reviewerEmail, subject, emailBody)
+        try {
+          await this.mailer.sendMail(reviewerEmail, subject, emailBody)
+        } catch (mailerErr) {
+          // Non-blocking
+          logger.error(
+            `Error when sending reviewer mail to ${reviewerEmail}: ${mailerErr}`
+          )
+        }
       })
     )